Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UploadControl: Added setAllowedType #172

Closed
wants to merge 1 commit into from

Conversation

@JanGalek
Copy link

commented Dec 6, 2017

  • bug fix? no
  • new feature? yes
  • BC break? no
  • doc PR: nette/docs#??? - if it will merged I will send PR

Added new method to UploadControl, whitch set mimeTypes and attribute accept.

@JanTvrdik

This comment has been minimized.

Copy link
Contributor

commented Dec 6, 2017

@JanGalek

This comment has been minimized.

Copy link
Author

commented Dec 6, 2017

@JanTvrdik ou, ok I will remove js, and rebase.

Firefox 👎

UploadControl: Added method for mime types
And add attribute accept with mime types

Removed empty line

Fix: condition to check type

Fix: conding-standard
@JanGalek

This comment has been minimized.

Copy link
Author

commented Dec 6, 2017

@JanTvrdik https://bugzilla.mozilla.org/show_bug.cgi?id=373621, fixed ?

I tried js log and firefox (57.0) return same type as chrome

@JanTvrdik

This comment has been minimized.

Copy link
Contributor

commented Dec 6, 2017

@JanGalek The commit is from 2014 and the issue is resolved. But it's still sth that need's to be considered.

@JanGalek

This comment has been minimized.

Copy link
Author

commented Dec 6, 2017

@JanTvrdik ok, and if we Dtect firefox <= 50 and type needed is application/pdf than we allow application/x-download with check extension ?

Problem was with PDF right ?

@dg

This comment has been minimized.

Copy link
Member

commented Feb 6, 2018

What about to add attribute accept, when rule MIME_TYPE is used? The same way as i.e. attribute range is added in TextInput::addRule().

@dg dg force-pushed the nette:master branch from 5f5aec3 to 9ea7e2e Feb 28, 2018

@dg dg force-pushed the nette:master branch from 5da3697 to 20559e9 Mar 20, 2018

@dg dg force-pushed the nette:master branch from 81a06eb to db99d41 May 10, 2018

@dg dg force-pushed the nette:master branch from 15ef159 to 1da7145 Jun 7, 2018

@dg dg force-pushed the nette:master branch from 95b9cfc to 177fbe3 Jun 28, 2018

@dg dg force-pushed the nette:master branch from 9561dd8 to d743dd9 Jul 27, 2018

@dg dg force-pushed the nette:master branch 3 times, most recently from 43a2ab1 to c2d4d93 Sep 12, 2018

@dg dg force-pushed the nette:master branch 2 times, most recently from f3a77d7 to 880142b Sep 30, 2018

@dg dg closed this in 5141f9b Sep 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.