Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UploadControl: Added setAllowedType #172

Closed
wants to merge 1 commit into from
Closed

UploadControl: Added setAllowedType #172

wants to merge 1 commit into from

Conversation

JanGalek
Copy link

@JanGalek JanGalek commented Dec 6, 2017

  • bug fix? no
  • new feature? yes
  • BC break? no
  • doc PR: nette/docs#??? - if it will merged I will send PR

Added new method to UploadControl, whitch set mimeTypes and attribute accept.

@JanTvrdik
Copy link
Contributor

@JanTvrdik JanTvrdik commented Dec 6, 2017

@JanGalek
Copy link
Author

@JanGalek JanGalek commented Dec 6, 2017

@JanTvrdik ou, ok I will remove js, and rebase.

Firefox 👎

And add attribute accept with mime types

Removed empty line

Fix: condition to check type

Fix: conding-standard
@JanGalek
Copy link
Author

@JanGalek JanGalek commented Dec 6, 2017

@JanTvrdik https://bugzilla.mozilla.org/show_bug.cgi?id=373621, fixed ?

I tried js log and firefox (57.0) return same type as chrome

@JanTvrdik
Copy link
Contributor

@JanTvrdik JanTvrdik commented Dec 6, 2017

@JanGalek The commit is from 2014 and the issue is resolved. But it's still sth that need's to be considered.

@JanGalek
Copy link
Author

@JanGalek JanGalek commented Dec 6, 2017

@JanTvrdik ok, and if we Dtect firefox <= 50 and type needed is application/pdf than we allow application/x-download with check extension ?

Problem was with PDF right ?

@dg
Copy link
Member

@dg dg commented Feb 6, 2018

What about to add attribute accept, when rule MIME_TYPE is used? The same way as i.e. attribute range is added in TextInput::addRule().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants