New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netteForms.js: support checking file name via pattern rule #186

Merged
merged 1 commit into from Jul 25, 2018

Conversation

Projects
None yet
2 participants
@renekliment
Copy link
Contributor

renekliment commented Jul 25, 2018

  • bug fix / new feature? a little bit of both
  • BC break? no
  • doc PR: not necessary I believe

This is a complement to #175 so validating file names via pattern works on both client and server.

I'm not sure how backporting to v2.4 works - do you do that manually? Anything I need to do?
Not sure how to write tests for this - to select a file in the test environment to test this. Appreciate any pointers.

Thank you.

netteForms.js: support checking file name via pattern rule using HTML…
…5 File API

* this is a complement to #175 so validating file names via pattern works on both client and server
@dg

This comment has been minimized.

Copy link
Member

dg commented Jul 25, 2018

Thanks! I'll backport it to 2.4

@dg dg merged commit ecca771 into nette:master Jul 25, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 95.025%
Details

dg added a commit that referenced this pull request Jul 25, 2018

netteForms.js: support checking file name via pattern rule using HTML…
…5 File API (#186)

* this is a complement to #175 so validating file names via pattern works on both client and server

@renekliment renekliment deleted the renekliment:js-file-pattern branch Jul 25, 2018

renekliment added a commit to renekliment/nette-docs that referenced this pull request Aug 22, 2018

dg added a commit to nette/docs that referenced this pull request Aug 22, 2018

dg added a commit to nette/docs that referenced this pull request Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment