Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultFormRenderer: Add control .error class #209

Merged
merged 1 commit into from Feb 9, 2019

Conversation

@jtojnar
Copy link
Contributor

commented Feb 9, 2019

Bootstrap 4 marks invalid controls with is-invalid class. Let’s allow to set this class in DefaultFormRenderer.

  • new feature
  • BC break? no
DefaultFormRenderer: Add control .error class
Bootstrap 4 marks invalid controls with is-invalid class.
Let’s allow to set this class in DefaultFormRenderer.

@jtojnar jtojnar force-pushed the jtojnar:control-error branch from e5c3a23 to c4f3331 Feb 9, 2019

@jtojnar jtojnar referenced this pull request Feb 9, 2019

Merged

Add Bootstrap 4 renderer #59

@dg

This comment has been minimized.

Copy link
Member

commented Feb 9, 2019

Thanks

@dg dg merged commit 11e21e5 into nette:master Feb 9, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 95.062%
Details

@jtojnar jtojnar deleted the jtojnar:control-error branch Feb 9, 2019

dg added a commit that referenced this pull request Feb 19, 2019

DefaultFormRenderer: Add control .error class (#209)
Bootstrap 4 marks invalid controls with is-invalid class.
Let’s allow to set this class in DefaultFormRenderer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.