-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert callable type of Form::$onSuccess to accept mixed #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/nette/forms/blob/d9fc6d6/src/Forms/Form.php#L84 Could you also change |
Currently best workaround is function(Form $form, $mappedValues): void {
/** @var MappedValues $values */
$mappedValues = $mappedValues;
} |
I've opened an issue for that (#224) but yes, |
@mabar I'm for |
jiripudil
changed the title
Add missing ArrayHash import
Use ArrayHash FQN in callable type in Form::$onSuccess
May 29, 2019
jiripudil
changed the title
Use ArrayHash FQN in callable type in Form::$onSuccess
Revert callable type of Form::$onSuccess to accept mixed
Jul 8, 2019
Updated the PR to fix #224 |
Thanks |
dg
pushed a commit
that referenced
this pull request
Jul 8, 2019
dg
pushed a commit
that referenced
this pull request
Jul 12, 2019
The second parameter for `onValidate` callback (`$values`) documented as `mixed` to follow the consensus for `onSuccess` (in #223)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See forum thread. The import was missing, causing static analysis to report false positives.