Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes using label placeholder in validation rule with Html label #235

Merged
merged 3 commits into from Nov 18, 2019

Conversation

@JanMikes
Copy link
Contributor

JanMikes commented Nov 18, 2019

Fixes #234

JanMikes added 3 commits Nov 18, 2019
? rtrim($rule->control->translate($rule->control->getCaption()), ':')
: null;
case 'label':
if ($rule->control instanceof Controls\BaseControl) {

This comment has been minimized.

Copy link
@JanMikes

JanMikes Nov 18, 2019

Author Contributor

I think this way (replacing ternary operator with if with early return) is more readable intead of having 2 nested ternary operators, but i am opened to adapt it to desired codestyle needs - there is missing some coding standard tool to force code style :-).

@dg

This comment has been minimized.

Copy link
Member

dg commented Nov 18, 2019

Thanks

@dg dg merged commit 1bf3cbb into nette:master Nov 18, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
dg added a commit that referenced this pull request Nov 18, 2019
dg added a commit that referenced this pull request Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.