Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes using label placeholder in validation rule with Html label #235

Merged
merged 3 commits into from Nov 18, 2019

Conversation

JanMikes
Copy link
Contributor

@JanMikes JanMikes commented Nov 18, 2019

Fixes #234

? rtrim($rule->control->translate($rule->control->getCaption()), ':')
: null;
case 'label':
if ($rule->control instanceof Controls\BaseControl) {
Copy link
Contributor Author

@JanMikes JanMikes Nov 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this way (replacing ternary operator with if with early return) is more readable intead of having 2 nested ternary operators, but i am opened to adapt it to desired codestyle needs - there is missing some coding standard tool to force code style :-).

@dg
Copy link
Member

@dg dg commented Nov 18, 2019

Thanks

@dg dg merged commit 1bf3cbb into nette:master Nov 18, 2019
1 check failed
dg pushed a commit that referenced this issue Nov 18, 2019
dg pushed a commit that referenced this issue Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants