Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strict fix #249

Merged
merged 1 commit into from Jun 8, 2020
Merged

strict fix #249

merged 1 commit into from Jun 8, 2020

Conversation

dakorpar
Copy link
Contributor

@dakorpar dakorpar commented Jun 8, 2020

  • bug fix
  • BC break? no

It breaked unit tests on project, not sure if it's only unit tests or also code related as well, but whenever I have container which name was numeric I'm getting exception:

TypeError : ReflectionClass::hasProperty() expects parameter 1 to be string, int given
 /var/www/vendor/nette/forms/src/Forms/Container.php:124

@mabar
Copy link
Contributor

mabar commented Jun 8, 2020

I guess it's related to php casting numeric strings to integers in array keys

$arr['123'] = 'key is string';
var_dump($arr);

// Key is not string, php casted it to int
/*
array(1) {
  [123]=>
  string(13) "key is string"
}
*/

@dg
Copy link
Member

dg commented Jun 8, 2020

Thans

@dg dg changed the title Allways cast control name to string in getValues strict fix Jun 8, 2020
@dg dg merged commit b4d63f4 into nette:master Jun 8, 2020
2 checks passed
@dakorpar dakorpar deleted the patch-1 branch Jun 8, 2020
@kravcik
Copy link

kravcik commented Jun 19, 2020

Is planned to tag this one in the near future?

@carloscz
Copy link

carloscz commented Jul 7, 2020

Is planned to tag this one in the near future?

+1 broken project :/ by 3.0.5 version

@Kocicak
Copy link

Kocicak commented Jul 16, 2020

Is planned to tag this one in the near future?

+1 broken project :/ by 3.0.5 version

+1 another broken project

@dg
Copy link
Member

dg commented Jul 16, 2020

3.0.6 is released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants