Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: validate() on forms where is attached non-form component causes error #86

Closed
wants to merge 1 commit into from

Conversation

@ovlach
Copy link

ovlach commented Jul 3, 2015

  • bugfix
  • documentation - not needed
  • BC break - no

validate() on forms where is attached non-form component causes error - older nette/form using getControls() method where is interface checking.

Now this is not possible, so i create special IValidatable interface which marks controls and container as validatable and checking it.

@ovlach ovlach changed the title Fix: validate() on forms where is attached non-form control causes error Fix: validate() on forms where is attached non-form component causes error Jul 3, 2015
@fprochazka

This comment has been minimized.

Copy link
Contributor

fprochazka commented Jul 3, 2015

I really like the solution, but I'm not 100% sure if this is not a bc break.

@dg

This comment has been minimized.

Copy link
Member

dg commented Jul 3, 2015

Related to 347c545

@dg dg force-pushed the nette:master branch from ec29b6d to 249f516 Nov 29, 2015
@dg dg force-pushed the nette:master branch from 728c43e to ffb3b6b Jan 11, 2016
@milo

This comment has been minimized.

Copy link
Member

milo commented Mar 29, 2016

@ovlach The interface is needless here. Can you simplyfied it by adding check that component is form Control or IContainer?

@Majkl578

This comment has been minimized.

Copy link
Contributor

Majkl578 commented Mar 29, 2016

I like the interface.
@milo: What you suggest is not correct as it merely relies on the method of same name being present, not enforced by any object contract.

@dg

This comment has been minimized.

Copy link
Member

dg commented Mar 30, 2016

Validation will be redesigned in future in another way and this interface is not (will not be) suitable.

@dg dg force-pushed the nette:master branch 2 times, most recently from 9e359e6 to fa84d63 Mar 30, 2016
@dg dg force-pushed the nette:master branch 2 times, most recently from 3c1619a to 31bc0a3 Apr 11, 2016
@dg dg force-pushed the nette:master branch 7 times, most recently from 6b04b51 to d1c30d6 Apr 20, 2016
@dg dg force-pushed the nette:master branch 5 times, most recently from fd381fb to b70e5da May 13, 2016
@dg dg force-pushed the nette:master branch 5 times, most recently from 9470e5f to 4d5f6c3 Jun 1, 2016
@dg dg force-pushed the nette:master branch 2 times, most recently from 81549c5 to 98832d3 Jun 7, 2016
@dg dg force-pushed the nette:master branch from 27cf0d0 to 31b9298 Jun 14, 2016
@dg dg force-pushed the nette:master branch 6 times, most recently from 2b44619 to 4473513 Jun 29, 2016
@dg dg closed this in e1457fa Jun 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.