Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is UserStorage::setExpiration with BROWSER_CLOSED working? #112

Closed
forrest79 opened this issue Dec 13, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@forrest79
Copy link

commented Dec 13, 2016

Hi,
we're using Nette\Security\User::setExpiration with $whenBrowserIsClosed = TRUE, that calls Nette\Security\UserStorage::setExpiration with flag BROWSER_CLOSED, but I think, that this functionality was removed in pullrequest #103 and then Nette\Security\User::setExpiration function with parametr $whenBrowserIsClosed and flag BROWSER_CLOSED for Nette\Security\UserStorage::setExpiration is unusable and should be removed too.

@dg

This comment has been minimized.

Copy link
Member

commented Dec 13, 2016

Good point.

@forrest79 forrest79 changed the title Is UserStorage::setExpiration with BROWSER_CLOSED worked? Is UserStorage::setExpiration with BROWSER_CLOSED working? Dec 13, 2016

@dg dg closed this in 745ca79 Dec 13, 2016

dg added a commit to nette/security that referenced this issue Dec 13, 2016

dg added a commit to nette/security that referenced this issue Dec 13, 2016

dg added a commit to nette/security that referenced this issue Dec 13, 2016

dg added a commit to nette/security that referenced this issue Dec 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.