Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url::getHostUrl() returns scheme only when host is '0' #158

Closed
spaze opened this issue Jun 28, 2019 · 0 comments · Fixed by #159
Closed

Url::getHostUrl() returns scheme only when host is '0' #158

spaze opened this issue Jun 28, 2019 · 0 comments · Fixed by #159

Comments

@spaze
Copy link
Contributor

@spaze spaze commented Jun 28, 2019

Version: master (3.0.1)

Bug Description

$url->getHostUrl() returns just scheme when the host is 0.

$url = new Url('https://0/0');
$url->getHostUrl();  // https:

Steps To Reproduce

This is a failing test

$url = new Url('https://0/0');
Assert::same('https://0', $url->getHostUrl());

Expected Behavior

The host (0) should be included.

Possible Solution

I'll send a PR in a second.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.