Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IResponse: added HTTP response codes from accepted RFC 6585 #107

Merged
merged 1 commit into from Oct 5, 2016

Conversation

@matyx
Copy link
Contributor

matyx commented Oct 3, 2016

Copy link
Contributor

fprochazka left a comment

@dg

This comment has been minimized.

Copy link
Member

dg commented Oct 5, 2016

Do you think this is useful?

@matyx

This comment has been minimized.

Copy link
Contributor Author

matyx commented Oct 5, 2016

@fprochazka Yes, I will add them.
@dg I need only 429 - Too many requests (for API). I added all from the RFC only because of completness

@fprochazka

This comment has been minimized.

Copy link
Contributor

fprochazka commented Oct 5, 2016

@dg it's better to have those codes as constants. And it's weird to have half defined in nette and half in custom class.

@Majkl578

This comment has been minimized.

Copy link
Contributor

Majkl578 commented Oct 5, 2016

There is even more codes missing here, see Symfony's Response constants: https://github.com/symfony/symfony/blob/c0a26bc/src/Symfony/Component/HttpFoundation/Response.php#L21-L82

@matyx matyx force-pushed the matyx:master branch from f8e7ac7 to 31322b5 Oct 5, 2016
@matyx

This comment has been minimized.

Copy link
Contributor Author

matyx commented Oct 5, 2016

I've added all missing response codes

@rostenkowski

This comment has been minimized.

Copy link
Contributor

rostenkowski commented Oct 5, 2016

🎩

@rostenkowski

This comment has been minimized.

Copy link
Contributor

rostenkowski commented Oct 5, 2016

As for community-driven development this a good pull request!

👍

@fprochazka

This comment has been minimized.

Copy link
Contributor

fprochazka commented Oct 5, 2016

@matyx awesome 👍

@dg dg merged commit d137702 into nette:master Oct 5, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 79.748%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.