Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UrlScript: accept option $scriptPath param in constructor #109

Merged
merged 1 commit into from Dec 3, 2016

Conversation

@JanTvrdik
Copy link
Contributor

JanTvrdik commented Nov 9, 2016

To alleviate the pain caused by 12ac75c I suggest adding optional parameter to UrlScript's constructor.

@JanTvrdik JanTvrdik force-pushed the JanTvrdik:pr/urlscript_constructor branch from 19846e7 to 6bd576d Nov 9, 2016
@JanTvrdik JanTvrdik force-pushed the JanTvrdik:pr/urlscript_constructor branch from 6bd576d to 45e99cc Nov 9, 2016
JanTvrdik referenced this pull request Nov 12, 2016
…al as the class Url (in method getBasePath, ...) [Closes #100]

(possible BC break)
@dg

This comment has been minimized.

Copy link
Member

dg commented Nov 13, 2016

Can you describe the pain?

@JanTvrdik

This comment has been minimized.

Copy link
Contributor Author

JanTvrdik commented Nov 14, 2016

@dg I had to replace all new UrlScript($url) with (new UrlScript($url))->setScriptPath('/'). This PR proposes to reduce the pain to new UrlScript($url, '/')

@JanTvrdik

This comment has been minimized.

Copy link
Contributor Author

JanTvrdik commented Dec 3, 2016

ping

@dg dg merged commit 5647551 into nette:master Dec 3, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 79.9%
Details
@JanTvrdik JanTvrdik deleted the JanTvrdik:pr/urlscript_constructor branch Dec 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.