Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take session ID from session_id() instead of cookie. #133

Closed
wants to merge 3 commits into from

Conversation

@KacerCZ
Copy link

KacerCZ commented Mar 6, 2018

  • bug fix? yes
  • new feature? no
  • BC break? no

Fixes #129
Session ID is taken from session_id() instead of cookie.

KacerCZ added 3 commits Mar 6, 2018
This fixes lost session when session ID is regenerated and then restarted.
@KacerCZ

This comment has been minimized.

Copy link
Author

KacerCZ commented Mar 6, 2018

AppVeyor fail is not related to this PR.

session_id($id);
} else {
unset($_COOKIE[session_name()]);
$id = session_id();

This comment has been minimized.

Copy link
@dg

dg Mar 14, 2018

Member

I tested it and it returns empty string when session is not started.

@dg dg closed this in a1a4023 Mar 14, 2018
dg added a commit that referenced this pull request Mar 14, 2018
dg added a commit that referenced this pull request Mar 14, 2018
dg added a commit that referenced this pull request Mar 14, 2018
dg added a commit that referenced this pull request Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.