Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpExtension: allow setup CSP in restrictive and report mode at the … #136

Closed
wants to merge 2 commits into from

Conversation

@PavelJurasek
Copy link
Contributor

PavelJurasek commented Mar 11, 2018

…same time

Solution for both modes of CSP.
Related to #135.

…same time
@PavelJurasek

This comment has been minimized.

Copy link
Contributor Author

PavelJurasek commented Mar 14, 2018

@spaze Do you think it's OK to use the same nonce for CSP and CSP-ReportOnly headers?

@dg

This comment has been minimized.

Copy link
Member

dg commented Mar 14, 2018

Thanks! (I've simplified code a little bit)

@dg dg closed this in edc6e04 Mar 14, 2018
dg added a commit that referenced this pull request Mar 14, 2018
…same time [Closes #136][Closes #135]
@PavelJurasek

This comment has been minimized.

Copy link
Contributor Author

PavelJurasek commented Mar 14, 2018

I thank you! 🙏
I'll be happy to see new release as it has been over 6 months since last release.

@spaze

This comment has been minimized.

Copy link
Contributor

spaze commented Mar 20, 2018

@PavelJurasek

Do you think it's OK to use the same nonce for CSP and CSP-ReportOnly headers?

It is. Also, nice addition, although csp-report might be a bit misleading, I'd suggest csp-report-only or something but it's probably too late.

@dg

This comment has been minimized.

Copy link
Member

dg commented Aug 28, 2018

I have changed option to cspReportOnly to be consistent with the rest of configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.