Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SessionExtension: added option handler to pass own SessionHandlerInterface #146

Merged
merged 1 commit into from Nov 23, 2018

Conversation

@milo
Copy link
Member

milo commented Nov 23, 2018

  • new feature
  • BC break? no

Own session handler cannot be set via session.save_handler, the ini_set() accepts string type only.
Can be solved by decorator extension:

decorator:
    Nette\Http\Session:
        setup:
            - setHandler(...)

but propesed way seems more suitable to me.

@dg

This comment has been minimized.

Copy link
Member

dg commented Nov 23, 2018

Thanks

@dg dg merged commit 0d9bfaf into nette:master Nov 23, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
dg added a commit that referenced this pull request Nov 23, 2018
dg added a commit that referenced this pull request Nov 23, 2018
dg added a commit that referenced this pull request Nov 23, 2018
@milo

This comment has been minimized.

Copy link
Member Author

milo commented Nov 30, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.