Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session: read_and_close configuration #156

Merged
merged 1 commit into from Jul 7, 2019
Merged

Conversation

@mabar
Copy link
Contributor

mabar commented Jun 18, 2019

Closes #155

Should be the only option which is configurable only in session_start.

@mabar mabar force-pushed the mabar:session-read-close branch 2 times, most recently from f54f2cf to d1338e5 Jun 18, 2019
@dg

This comment has been minimized.

Copy link
Member

dg commented Jul 3, 2019

Because session is configured via setOptions(), it would seem better to me to use setOptions('['read_and_close' => true]) than use constructor. What do you think?

@mabar

This comment has been minimized.

Copy link
Contributor Author

mabar commented Jul 4, 2019

Okay. I will add check that read_and_close is only configured before session started

@mabar mabar force-pushed the mabar:session-read-close branch from d1338e5 to 24f3545 Jul 6, 2019
@mabar mabar force-pushed the mabar:session-read-close branch from 24f3545 to 4000f7f Jul 6, 2019
@mabar

This comment has been minimized.

Copy link
Contributor Author

mabar commented Jul 6, 2019

@dg Ready.

@dg

This comment has been minimized.

Copy link
Member

dg commented Jul 7, 2019

Great, thanks!

@dg dg merged commit 8997102 into nette:master Jul 7, 2019
2 of 3 checks passed
2 of 3 checks passed
coverage/coveralls Coverage decreased (-0.3%) to 82.805%
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.