Url: Host should end with dot which should be removed. #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So canonicalize() should be fixed, not constructor. |
|
@dg Moved. I thought canonize() should be deprecated (from the last version). |
|
Great. Probably the same applies to isEqual(). Can you also add test? |
dg
force-pushed
the
master
branch
4 times, most recently
from
6ee31b8 to
4f4a403
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
a8895b6 to
9409a5f
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
7b7f9ff to
78bee95
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
59f402a to
32af756
Compare
dg
force-pushed
the
master
branch
12 times, most recently
from
ba7eba8 to
7774190
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
c6e0524 to
788ddc4
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
0f24022 to
ebdb825
Compare
dg
force-pushed
the
master
branch
7 times, most recently
from
684be2b to
2a0c595
Compare
dg
added a commit
that referenced
this pull request
Mar 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Domain
https://google.com./abcd(host ending with dot) is valid URL, but it is same ashttps://google.com/abcd.