-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request: Move Basic Auth credential from Url to Request due to prevent leak it #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg
pushed a commit
that referenced
this pull request
Mar 1, 2022
dg
pushed a commit
that referenced
this pull request
Apr 12, 2022
dg
pushed a commit
that referenced
this pull request
Sep 6, 2022
dg
pushed a commit
that referenced
this pull request
Oct 13, 2022
dg
pushed a commit
that referenced
this pull request
Oct 13, 2022
dg
pushed a commit
that referenced
this pull request
Oct 13, 2022
dg
pushed a commit
that referenced
this pull request
Nov 24, 2022
dg
pushed a commit
that referenced
this pull request
Nov 24, 2022
dg
pushed a commit
that referenced
this pull request
Nov 24, 2022
dg
pushed a commit
that referenced
this pull request
Nov 24, 2022
dg
pushed a commit
that referenced
this pull request
Nov 25, 2022
dg
pushed a commit
that referenced
this pull request
Nov 25, 2022
dg
pushed a commit
that referenced
this pull request
Nov 27, 2022
dg
pushed a commit
that referenced
this pull request
Nov 27, 2022
dg
pushed a commit
that referenced
this pull request
Nov 27, 2022
dg
pushed a commit
that referenced
this pull request
Nov 27, 2022
this should be released as new major to comply with semver :/ |
@carloscz There were security reasons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently is too risky use
Url
object from fromHttp\Request
created from global, because it can simply cause to leak user's credentials:The
Url
object already provide method–>withoutUserInfo()
to remove user credential, but when programer forgot to use that, the credentials can leaks.This PR ir removing user's credentials from
Url
object and move it toHttp\Request
directly.It's based on czech discussion at Nette Forum: https://forum.nette.org/cs/33127-http-basic-login-http-url-nette-3-security-issue
I know, it's too naive PR, here is missing any way to notify developer the
Url->getUser()
no more get user from current request. This PR sent as initiation of change insecurity.