New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequestFactory: rejects invalid URL [WIP] #41

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@dg
Member

dg commented Dec 27, 2014

See #30

@JanTvrdik

This comment has been minimized.

Contributor

JanTvrdik commented Dec 27, 2014

👍 This is exactly what I had in mind. Now we just need to figure out how to handle the invalid request 😄


Partially related to it – what should RequestFactory do when running in CLI? Because that is another form of invalid URL (or HTTP request in general).


You can remove the Strings::fixEncoding now as well.

@dg dg added this to the v2.4 milestone Feb 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment