Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend filter method safeUrl #203

Closed
geniv opened this issue Nov 19, 2019 · 1 comment
Closed

extend filter method safeUrl #203

geniv opened this issue Nov 19, 2019 · 1 comment

Comments

@geniv
Copy link

@geniv geniv commented Nov 19, 2019

I found an interesting thing, the safeUrl method leaves http / https / ftp and mailto protocols in the url. Personally, I think there may be other exceptions nowadays, for example: tel / callto / sms (and even fax) / skype / whatsapp / market / callto; so there is no need to use a solution like "nocheck".

source:

https://css-tricks.com/the-current-state-of-telephone-links/

https://digitalfortress.tech/tricks/creating-direct-click-to-call-sms-links/

https://beradrian.wordpress.com/2010/01/15/special-links/

@dg
Copy link
Member

@dg dg commented Jan 14, 2020

Good idea, I will add tel: & sms: yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants