Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.9.0 breaks Nittro macros #236

Closed
jahudka opened this issue Nov 16, 2020 · 2 comments
Closed

2.9.0 breaks Nittro macros #236

jahudka opened this issue Nov 16, 2020 · 2 comments

Comments

@jahudka
Copy link

jahudka commented Nov 16, 2020

Version: 2.9.0

Bug Description

As of Latte v2.9.0 the Nittro macros are broken because they contain an invalid character. That character being the dot (.).

Steps To Reproduce

  1. Nette skeleton
  2. composer require nittro/nette-bridges
  3. Put {snippet.id content} in any Latte template
  4. Navigate to the page using that template in the browser

Expected Behavior

I expected this to work the same as pre-2.9.0.

Possible Solution

Allow the dot (.) in the tag name.

I'm sorry, I'm not very up-to-date with what's new in Nette these days, if there's a perfectly good reason to prohibit dots in Latte tag names I'll work around this somehow (if that's the case, is there another character we can use as a separator in tag names?).

@dg
Copy link
Member

dg commented Nov 16, 2020

There is no reason to disable the dot, fixed.

@jahudka
Copy link
Author

jahudka commented Nov 16, 2020

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants