Skip to content

Notice when used n:ifcontent and n:snippet #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
janfejtek opened this issue Nov 23, 2020 · 3 comments
Closed

Notice when used n:ifcontent and n:snippet #243

janfejtek opened this issue Nov 23, 2020 · 3 comments

Comments

@janfejtek
Copy link

Version: 2.9.0

Bug Description

When used n:ifcontent and n:snippet on a same element, notice is raised: Undefined variable: __loc

Steps To Reproduce

<div n:ifcontent n:snippet="test"></div>

Expected Behavior

Throw exception that makes sense or do not create notice.

Possible Solution

  • throw exception with invalid tag usage, something like "do not use ifcontent and snippet on same element as it might produce unexpected behavior"
    OR
  • add isset check
@dg
Copy link
Member

dg commented Nov 23, 2020

Can you check 2.9-dev?

@janfejtek
Copy link
Author

Notice is different - Undefined variable: __ifc

@dg
Copy link
Member

dg commented Nov 23, 2020

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants