Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserNotice: The assignment in the ... looks like an error. #258

Closed
patrik-owly opened this issue Jan 30, 2021 · 4 comments
Closed

UserNotice: The assignment in the ... looks like an error. #258

patrik-owly opened this issue Jan 30, 2021 · 4 comments

Comments

@patrik-owly
Copy link

patrik-owly commented Jan 30, 2021

Version: v2.10.1

Bug Description

UserNotice: The assignment in the ... looks like an error.
Assigning to $primaryString variable which is used immediately on next line ($iePrimary === $primaryString)

Steps To Reproduce

{include #body-row,
	$recordVariable => $record,
	primaryString => ($primaryString = ($record |primaryToString)),
	isInlineEdited => $hasInlineEdit && $iePrimary === $primaryString
}

Same issue as in uestla/TwiGrid#40

@dg
Copy link
Member

dg commented Jan 31, 2021

fixed

@tprochazka
Copy link

tprochazka commented Feb 6, 2021

Weird that it is even worse in 2.10.1, it still crashing and also shows the wrong line number.
I'm using uestla/twigrid in version "12.0.0"

image

@dg
Copy link
Member

dg commented Feb 7, 2021

Did you try master?

@tprochazka
Copy link

tprochazka commented Feb 8, 2021

No, just 2.10.1. I tested it now with
latte/latte (v2.10.x-dev a5946ee): Cloning a5946ee1a7 from cache
And it is really fixed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants