Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlockMacros - define: fixed variables extracting #131

Merged
merged 1 commit into from Aug 18, 2016

Conversation

@matej21
Copy link
Contributor

matej21 commented Aug 15, 2016

...when named parameters are used

currently, even global variables like $basePath are not available...

@dg

This comment has been minimized.

Copy link
Member

dg commented Aug 15, 2016

That was intentional ... I understand that in some situations it may be undesirable.

@matej21

This comment has been minimized.

Copy link
Contributor Author

matej21 commented Aug 15, 2016

I was afraid of this answer. So what do you suggest? What about extracting only global params?

@dg

This comment has been minimized.

Copy link
Member

dg commented Aug 15, 2016

Global params seems like good compromise.

@matej21 matej21 force-pushed the matej21:fix/define_parameters branch from 98fc98b to c020029 Aug 15, 2016
@matej21

This comment has been minimized.

Copy link
Contributor Author

matej21 commented Aug 15, 2016

updated

@dg

This comment has been minimized.

Copy link
Member

dg commented Aug 18, 2016

Thanks

@dg dg merged commit fec7bd4 into nette:master Aug 18, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.