Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added {include with blocks} as a successor to {includeblock} #152

Merged
merged 1 commit into from Nov 23, 2020

Conversation

dg
Copy link
Member

@dg dg commented Jan 17, 2017

  • bug fix? ~
  • new feature? yes
  • BC break? no

There are use cases where {includeblock} is useful and cannot be substituted by {import}. But the name {includeblock} is misleading. This is attempt to solve it by more understandable {include with blocks 'file.latte'}

Cons: this introduces syntax which is not common in Latte.

https://forum.nette.org/cs/26699-latte-vypis-bloku-do-include

@JanTvrdik
Copy link
Contributor

I hate the syntax. Also include related stuff are changed way too often -> deeper analysis is required.

@dg
Copy link
Member Author

dg commented Jan 17, 2017

Do you have a better idea about syntax?

@JanTvrdik
Copy link
Contributor

Not yet. I don't want to rush this change just to change it in two weeks again.

@dg
Copy link
Member Author

dg commented Jan 17, 2017

I don't know what are you talking about.

@f3l1x
Copy link
Member

f3l1x commented Jan 17, 2017

The syntax {include-with-blocks} is forbidden?

@dg
Copy link
Member Author

dg commented Jan 18, 2017

{include-with-blocks} is not common in Latte too. More expectable is {includewithblocks} (hard to read) or {includeWithBlocks}.

@dg dg force-pushed the master branch 14 times, most recently from 04cdb42 to 1870016 Compare November 21, 2020 14:17
@dg dg force-pushed the master branch 9 times, most recently from f1158da to 7957380 Compare November 23, 2020 13:46
@dg dg changed the base branch from master to v2.9 November 23, 2020 15:04
@dg
Copy link
Member Author

dg commented Nov 23, 2020

Changed to {include file.latte with blocks}

@dg dg merged commit d147632 into nette:v2.9 Nov 23, 2020
@dg dg deleted the includeblock branch November 23, 2020 15:05
dg added a commit that referenced this pull request Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants