Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters: remove string type hints from replace filter #189

Merged
merged 2 commits into from Feb 20, 2019

Conversation

@pavolbiely
Copy link
Contributor

pavolbiely commented Feb 20, 2019

A long time ago it was possible to use the replace filter like this:
{$var|replace:[' ','+']:['','00']}

Today it ends up like this:
Argument 3 passed to Latte\Runtime\Filters::replace() must be of the type string, array given

Is it possible to avoid this BC break?

pavolbiely added 2 commits Feb 20, 2019
Filters: removed string type hints from replace filter
@dg

This comment has been minimized.

Copy link
Member

dg commented Feb 20, 2019

Thanks

@dg dg merged commit 2c310b9 into nette:master Feb 20, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adaamz

This comment has been minimized.

Copy link

adaamz commented Feb 20, 2019

Isnt string[] better than general array?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.