Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message: improved regexp for seaching embedded images #29

Closed
wants to merge 1 commit into from

Conversation

@JanTvrdik
Copy link
Contributor

JanTvrdik commented Jun 3, 2016

This reduces the BC break caused by e02911a.

There is another problem – only a single attribute of given element is processed, i.e. the following will not work. I did not find an easy way to solve this without processing the HTML multiple times.

<td background=background.png style="background:url(background.png)">
@dg

This comment has been minimized.

Copy link
Member

dg commented Jun 6, 2016

I believe that attribute background is allowed only on element body.

Possible solution is to deprecate current analyser and replace it with new syntax, for example

<td background=[[background.png]] style="background:url([[background.png]])">

to allow simplify regexp in future.

@dg dg closed this in c44b355 Jun 25, 2016
dg added a commit that referenced this pull request Jun 25, 2016
dg added a commit that referenced this pull request Jun 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.