Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neon syntax: deprecated keywords on/off #41

Merged
merged 1 commit into from Mar 26, 2019
Merged

Neon syntax: deprecated keywords on/off #41

merged 1 commit into from Mar 26, 2019

Conversation

dg
Copy link
Member

@dg dg commented Mar 1, 2019

  • BC break? yes

Deprecated rarely used on/off in favour of true/false and yes/no

@gscpeep
Copy link

@gscpeep gscpeep commented Mar 21, 2019

👍

@mabar
Copy link
Contributor

@mabar mabar commented Mar 21, 2019

Why not to be strict and accept only true/false?

@dg
Copy link
Member Author

@dg dg commented Mar 21, 2019

Because yes/no is widely used in Nette projects.

@milo
Copy link
Member

@milo milo commented Mar 22, 2019

And it is shorter and better "English" and I'm using it too :)

@dg dg merged commit fecb575 into nette:master Mar 26, 2019
2 checks passed
@dg dg deleted the on/off branch Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants