Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neon syntax: deprecated keywords on/off #41

Merged
merged 1 commit into from Mar 26, 2019
Merged

Neon syntax: deprecated keywords on/off #41

merged 1 commit into from Mar 26, 2019

Conversation

@dg
Copy link
Member

dg commented Mar 1, 2019

  • BC break? yes

Deprecated rarely used on/off in favour of true/false and yes/no

@gscpeep

This comment has been minimized.

Copy link

gscpeep commented Mar 21, 2019

👍

@mabar

This comment has been minimized.

Copy link

mabar commented Mar 21, 2019

Why not to be strict and accept only true/false?

@dg

This comment has been minimized.

Copy link
Member Author

dg commented Mar 21, 2019

Because yes/no is widely used in Nette projects.

@milo

This comment has been minimized.

Copy link
Member

milo commented Mar 22, 2019

And it is shorter and better "English" and I'm using it too :)

@dg dg merged commit fecb575 into nette:master Mar 26, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.04%) to 95.652%
Details
@dg dg deleted the dg:on/off branch Mar 26, 2019
dg added a commit that referenced this pull request Jul 8, 2019
dg added a commit that referenced this pull request Nov 13, 2019
dg added a commit that referenced this pull request Nov 13, 2019
dg added a commit that referenced this pull request Nov 19, 2019
dg added a commit that referenced this pull request Dec 10, 2019
dg added a commit that referenced this pull request Dec 11, 2019
dg added a commit that referenced this pull request Dec 19, 2019
dg added a commit that referenced this pull request Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.