Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing @method annotations breaks Form documentation #1344

Closed
tmysik opened this issue Jan 10, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@tmysik
Copy link

commented Jan 10, 2014

This applies for Nette 2.1, Nette 2.0 does not have this issue.

Steps:

  • create your own base form class
  • register some extension method for it (e.g. "addDateTime()")
  • since you of course want to have this new method in code completion of your favorite IDE (NetBeans in my case), add this new extension method to the class documentation using @method annotation (since this is the standard and expected way, right?)

-> when such form is created, Nette from some reason (why?) parses these annotations and magically handles [get/set/add/remove] prefixes (again - why? is it really worth to save those few lines of implementations or using a trait? I doubt...) - but it horribly fails here, of course, since this is not the case Nette expects.

Currently, I don't see any possible workaround for this issue and I had to remove all the @method annotations so the code completion in my IDE is incomplete/broken :/

Thanks for understanding.

@PavelJurasek

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2014

Fix in #1230

@tmysik

This comment has been minimized.

Copy link
Author

commented Jan 10, 2014

Perfect, thanks a lot!

@tmysik tmysik closed this Jan 10, 2014

dg added a commit that referenced this issue Jan 11, 2014

dg added a commit that referenced this issue Jan 11, 2014

dg added a commit that referenced this issue Jan 20, 2014

dg added a commit that referenced this issue Feb 3, 2014

dg added a commit that referenced this issue Feb 3, 2014

dg added a commit that referenced this issue Feb 3, 2014

dg added a commit that referenced this issue Feb 8, 2014

dg added a commit to nette/utils that referenced this issue Mar 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.