Default presenter names inconsistency #66

Closed
ondrejmirtes opened this Issue Jun 25, 2010 · 2 comments

Comments

Projects
None yet
3 participants
@ondrejmirtes
Contributor

ondrejmirtes commented Jun 25, 2010

Default presenter in tools/Skeleton is named HomepagePresenter, but in Application.php on line 120, there is setup of default router in case no routers are defined in bootstrap. And the name of the presenter in the default router is Default, which is inconsistent to the referral and recommended name in Skeleton.

@jantichy

This comment has been minimized.

Show comment
Hide comment
@jantichy

jantichy Aug 6, 2010

Contributor

Hi, in my opinion the "Homepage" name for the default presenter is weird, because the homepage is usually only once on the web X i can have multiple modules, each with its default presenter. So IMHO much better solution is to rename HomepagePresenter to DefaultPresenter in Skeleton.

Contributor

jantichy commented Aug 6, 2010

Hi, in my opinion the "Homepage" name for the default presenter is weird, because the homepage is usually only once on the web X i can have multiple modules, each with its default presenter. So IMHO much better solution is to rename HomepagePresenter to DefaultPresenter in Skeleton.

@dg

This comment has been minimized.

Show comment
Hide comment
@dg

dg Nov 10, 2010

Member

fixed

Member

dg commented Nov 10, 2010

fixed

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment