Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POST data overwrite persistent parameters. #1061

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@pepakriz
Copy link
Contributor

commented Apr 18, 2013

These lines are redundant in my opinion. When I send data from AJAX form, I lost persistent data with the same name as form-input name.

POST data overwrite persistent parameters.
These lines are redundant in my opinion. When I send data from AJAX form, I lost persistent data with the same name as form-input name.
@Majkl578

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2013

No, you do not. Provide test case.
Merging arrays with "+" doesn't work that way, it preserves keys and their values from the left-most array. Imho the only case is with parameters with default value which are not in $params.
Additionally, this is huge BC.

@pepakriz

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2013

Sorry, you are right. If current value is NULL (or default), it changes persistent parameter. But problem with rewriting value is still here. I don't understand the meaning of these lines. In which case can I use this 'feature'?

@JanTvrdik

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2013

👎 This would break almost every application using AJAX.

@dg

This comment has been minimized.

Copy link
Member

commented Apr 18, 2013

From my point of view, there is no difference between GET and POST AJAX request.

@dg dg force-pushed the nette:master branch 3 times, most recently from 991ba1a to e23de7a Aug 26, 2014

@dg dg force-pushed the nette:master branch from 872d693 to 1467a8d Jan 31, 2015

dg added a commit to dg/nette-application that referenced this pull request Apr 1, 2016

dg added a commit to dg/nette-application that referenced this pull request Apr 1, 2016

dg added a commit to dg/nette-application that referenced this pull request Apr 1, 2016

dg added a commit to dg/nette-application that referenced this pull request Apr 16, 2016

dg added a commit to nette/application that referenced this pull request Apr 30, 2016

dg added a commit to nette/application that referenced this pull request Apr 30, 2016

dg added a commit to nette/application that referenced this pull request Apr 30, 2016

dg added a commit to nette/application that referenced this pull request May 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.