Database: Selection::find() renamed to wherePrimary() #953

Merged
merged 1 commit into from Feb 14, 2013

Conversation

Projects
None yet
6 participants
@hrach
Contributor

hrach commented Feb 6, 2013

@fprochazka

This comment has been minimized.

Show comment Hide comment
@fprochazka

fprochazka Feb 7, 2013

Contributor

Good idea.

Contributor

fprochazka commented Feb 7, 2013

Good idea.

@dg

This comment has been minimized.

Show comment Hide comment
@dg

dg Feb 7, 2013

Owner

And what about order() --> orderBy() & orderByDescending()?

Owner

dg commented Feb 7, 2013

And what about order() --> orderBy() & orderByDescending()?

@Vrtak-CZ

This comment has been minimized.

Show comment Hide comment
@Vrtak-CZ

Vrtak-CZ Feb 7, 2013

Contributor

👍

Contributor

Vrtak-CZ commented Feb 7, 2013

👍

@fprochazka

This comment has been minimized.

Show comment Hide comment
@fprochazka

fprochazka Feb 7, 2013

Contributor

I can't figure out if @dg was ironical :)

Contributor

fprochazka commented Feb 7, 2013

I can't figure out if @dg was ironical :)

@JanTvrdik

This comment has been minimized.

Show comment Hide comment
@JanTvrdik

JanTvrdik Feb 7, 2013

Contributor

@hosiplan: yes, he is :)

Contributor

JanTvrdik commented Feb 7, 2013

@hosiplan: yes, he is :)

@hrach

This comment has been minimized.

Show comment Hide comment
@hrach

hrach Feb 7, 2013

Contributor

@hosiplan & @JanTvrdik: Because @dg mentioned sth similar, I'm not sure too. See http://forum.nette.org/cs/7706-api-pro-nette-database-table-selection#p58350.

Situation with order() is quite different. Order accepts FULL (order) expression, so changing to (adding) orderByDescending() would require also complete refactoring, otherwise would be possible:

$selection->orderByDescending('id ASC, name'); 
// ORDER BY id ASC, name DESC

I have nothing against order() -> orderBy().

Contributor

hrach commented Feb 7, 2013

@hosiplan & @JanTvrdik: Because @dg mentioned sth similar, I'm not sure too. See http://forum.nette.org/cs/7706-api-pro-nette-database-table-selection#p58350.

Situation with order() is quite different. Order accepts FULL (order) expression, so changing to (adding) orderByDescending() would require also complete refactoring, otherwise would be possible:

$selection->orderByDescending('id ASC, name'); 
// ORDER BY id ASC, name DESC

I have nothing against order() -> orderBy().

@dg

This comment has been minimized.

Show comment Hide comment
@dg

dg Feb 14, 2013

Owner

No, I am not ironical.

Owner

dg commented Feb 14, 2013

No, I am not ironical.

dg added a commit that referenced this pull request Feb 14, 2013

Merge pull request #953 from hrach/db-rename
Database: Selection::find() renamed to wherePrimary()

@dg dg merged commit 1a51cb6 into nette:master Feb 14, 2013

1 check passed

default The Travis build passed
Details
@vojtech-dobes

This comment has been minimized.

Show comment Hide comment
@vojtech-dobes

vojtech-dobes Feb 14, 2013

Contributor

There should be return for full BC. Sorry for late review :).

There should be return for full BC. Sorry for late review :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment