Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SafeStream: prevents unnecessary error during register #6

Closed
wants to merge 1 commit into from

Conversation

@salatos
Copy link
Contributor

salatos commented Feb 29, 2016

The main reason of this changes is that if error during unregistration of stream happens, php remebers it even if it is suppressed. And SafeStream::register is called in composer autoloading process. So whenever is vendor/autoload.php used, it produces that error. Some third party packages displays the last error by error_get_last() function and it's annoying and unnecessary I think and it can be preveted by this fix.

@salatos

This comment has been minimized.

Copy link
Contributor Author

salatos commented Feb 29, 2016

Could someone please tell me what is wrong with my test? I don't get the whitespace thing ..

@dg

This comment has been minimized.

Copy link
Member

dg commented Feb 29, 2016

Fix third party packages, this is absolutely correct.

@salatos

This comment has been minimized.

Copy link
Contributor Author

salatos commented Mar 1, 2016

I disagree, because in Nette I understand it and I can adapt to it, but if it is affecting environment out of Nette, it is bad in my opinion (I am talking about project-managing helpful scripts). But hey, I can live with that.

@dg

This comment has been minimized.

Copy link
Member

dg commented Mar 1, 2016

There are a lot of places where PHP produces error and it is suppressed, so there always will be some last error.

@JanTvrdik

This comment has been minimized.

Copy link

JanTvrdik commented Mar 1, 2016

@salatos In PHP 7 you may call error_clear_last after loading SafeStream.

@salatos

This comment has been minimized.

Copy link
Contributor Author

salatos commented Mar 1, 2016

@JanTvrdik Thanks for the tip!

Still please, what is wrong with my test (for the future contributing)? I can't figure it out .. or should I ask on phorum? Thanks alot.

@dg dg closed this in 4b9bb32 Mar 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.