Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert with custom message. #7

Closed
integer opened this issue Jun 26, 2019 · 2 comments
Closed

Assert with custom message. #7

integer opened this issue Jun 26, 2019 · 2 comments

Comments

@integer
Copy link
Contributor

@integer integer commented Jun 26, 2019

When you have more asserts for one value it is difficult to find which assert failed.

Same issue if you have more complex logic in your assert. For example you asserts relations between two fields of structure. In this case you get error like this
Failed assertion #0 for option 'data › items › 0' with value object. which is not so useful.

What do you think about this feature. May I prepare PR?

@dg
Copy link
Member

@dg dg commented Jul 7, 2019

How would you like to solve it?

integer added a commit to integer/schema that referenced this issue Jul 11, 2019
integer added a commit to integer/schema that referenced this issue Jul 11, 2019
integer added a commit to integer/schema that referenced this issue Jul 11, 2019
integer added a commit to integer/schema that referenced this issue Jul 11, 2019
integer added a commit to integer/schema that referenced this issue Jul 11, 2019
dg pushed a commit that referenced this issue Sep 15, 2019
@dg
Copy link
Member

@dg dg commented Sep 15, 2019

Merged

@dg dg closed this as completed Sep 15, 2019
dg pushed a commit that referenced this issue Sep 15, 2019
dg pushed a commit that referenced this issue Sep 15, 2019
dg pushed a commit that referenced this issue Sep 24, 2019
dg pushed a commit that referenced this issue Oct 31, 2019
dg pushed a commit that referenced this issue Oct 31, 2019
dg pushed a commit that referenced this issue Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants