Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

tests: PhpExecutable uses proper php.ini #109

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Member

milo commented Mar 6, 2014

No description provided.

Member

milo commented Mar 6, 2014

Maybe related to #88

Owner

dg commented Mar 6, 2014

-c can be "empty", so what about shorter

$php = new Tester\Runner\PhpExecutable(PHP_BINARY, '-n -c ' . Tester\Helpers::escapeArg(php_ini_loaded_file()));
$runner = new Tester\Runner\Runner($php);

@dg dg added a commit to dg/tester that referenced this pull request Mar 6, 2014

@dg dg tests: PhpExecutable uses proper php.ini [Closes #109] 35b0081
Member

milo commented Mar 6, 2014

@dg That's better. Should I update PR or will you close it by your commit? Btw. I found it in PhpExecutable.phpt too.

Owner

dg commented Mar 6, 2014

What do you think about default -n, direct in PhpExecutable or Job class?

Member

milo commented Mar 6, 2014

Part of PhpExecutable is better. I think that default php.ini should be always prohibited for Tester's purpose.

@dg dg closed this in 5c5ecba Mar 8, 2014

@milo milo deleted the milo:pull-create-php branch Mar 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment