Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplexml must be required #401 #419

Closed
wants to merge 1 commit into from
Closed

simplexml must be required #401 #419

wants to merge 1 commit into from

Conversation

villfa
Copy link

@villfa villfa commented Jun 27, 2020

The \SimpleXMLElement class is used under the src/ directory (see below) so the simplexml extension must be required to avoid a class not found error.

class DomQuery extends \SimpleXMLElement

@dg dg closed this in 170b379 Jun 28, 2020
@villfa villfa deleted the patch-1 branch Jun 29, 2020
@villfa
Copy link
Author

villfa commented Jun 29, 2020

@dg I understand that my proposition doesn't satisfy you (I guess you don't want ext-simplexml to be required for installing the library) but the 170b379 commit won't fix the issue.

The condition cannot be evaluated since the class not found error happens when the class is declared.

Another solution could be to move this condition to bootstrap.php.

@dg
Copy link
Member

dg commented Jul 13, 2020

Oh yes! I used your solution with bootstrap.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants