-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture stderr to temp file and output it in test results #438
Conversation
MartinMystikJonas
commented
Jul 10, 2022
- new feature
- BC break: no (only additional output in test results)
df88741
to
889769a
Compare
Any idea why output tests on my computer works just fine but fails in GitHub actions? Output does not match but it seems it should. I suspect some whitespace difference but cannot find it. |
5cca3ef
to
4d35048
Compare
I still struggle to find what causes tests to fail only in CI. I identified that it is caused by spaces only lines in actual output on CI that does not happens on by local build. But I have no idea why. I will do some more experimentation to find it. |
0d3094b
to
43ca562
Compare
43ca562
to
99f9da3
Compare
40e04d0
to
2e32ffe
Compare
Looks great. I'll polish it a little bit and I'll merge it. |
@MartinMystikJonas Are you OK with such modifications? https://github.com/milo/tester/tree/MartinMystikJonas-stderr-file |
@milo Looks OK |
@milo Is there anything I should do now to finish this PR? |
Thank you. I've merged it. |
Do you have any idea why the actual:
expected:
|
I have seen something similar when temp dir was not purged between individual tests so order of executed tests prioritized failed ones. Why it happens on windows I do not know. |
Bingo, thanks! |