Fix PHP 8.5 deprecation: null as array offset in -o option handler #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 8.5 deprecated using null as an array offset. When running `-o console` without a filename, $file was null and used as array key in $outputFiles[$file], triggering E_DEPRECATED which the strict error handler converted to a fatal error. Changed the default from null to empty string '' and updated the corresponding null checks to check for empty string instead.
Contributor
Author
|
Unlucky, |
Member
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
-o consolewithout a filenamenullas an array offset; when no filename is specified,$filewasnulland used as key in$outputFiles[$file]nullto empty string''and updated corresponding checksTest plan
src/tester tests -s -C$file ?: 'php://output'which handles empty string the same as null)