Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracy is unexpectedly dependent to php-xml extenstion #212

Closed
jakubboucek opened this issue Jul 27, 2016 · 6 comments
Closed

Tracy is unexpectedly dependent to php-xml extenstion #212

jakubboucek opened this issue Jul 27, 2016 · 6 comments

Comments

@jakubboucek
Copy link
Contributor

@jakubboucek jakubboucek commented Jul 27, 2016

From PHP 7 is Tracy unexpectedly dependent to php-xml extenstion (is using function utf8_decode().

It is probably problem only with @oerdnj 's PPA packages. Really i don't know if is that fskutečnosti relevant to Tracy, but that PPAs are very popular (only one trust source for builded & updated PHP on Ubuntu) and Nette should be verify availability of extension in composer.json.

I can send PR, please only confirm I am thinking right.

@dg

This comment has been minimized.

Copy link
Member

@dg dg commented Jul 28, 2016

Isn't it better to fix PPA package?

@jakubboucek

This comment has been minimized.

Copy link
Contributor Author

@jakubboucek jakubboucek commented Jul 28, 2016

I mean it's not a bug but feature (make it basic package lighter). Maybe similar reason why you splitted Nette to few packages.

Or exists anywhere list of packages standardly turned-on in a base PHP build? If is, it can be good argument for @oerdnj to add distinct note about differences compared to the standard.

@oerdnj

This comment has been minimized.

Copy link

@oerdnj oerdnj commented Jul 28, 2016

There's nothing to fix in the PPA.

@Majkl578

This comment has been minimized.

Copy link
Contributor

@Majkl578 Majkl578 commented Jul 28, 2016

By the way, this also applies to next Debian, not only the mentioned PPA.
Also ext-json is undeclared by nette/tracy. Also there is hidden dependency in required nette/di package on ext-tokenizer.

You can easily verify this e.g. in Docker: run debian:testing image, install php7.0-cli, clone tracy and run tests (you will also need to explicitly enable these extensions e.g. by -d extension=json.so since tester ignores system-wide configuration).

@dg

This comment has been minimized.

Copy link
Member

@dg dg commented Jul 30, 2016

PHP extension session is disabled in PPA too?

@dg dg closed this in 3c4a159 Jul 30, 2016
dg added a commit that referenced this issue Jul 31, 2016
@jakubboucek

This comment has been minimized.

Copy link
Contributor Author

@jakubboucek jakubboucek commented Aug 1, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.