Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated opening/closing of panel shifts it's position up and left #318

Closed
adrianbj opened this issue Sep 21, 2018 · 0 comments
Closed

Repeated opening/closing of panel shifts it's position up and left #318

adrianbj opened this issue Sep 21, 2018 · 0 comments

Comments

@adrianbj
Copy link
Contributor

@adrianbj adrianbj commented Sep 21, 2018

Version: 2.5.2

Bug Description

av2ricbsgv

Steps To Reproduce

Keep clicking on the tab icon for a panel so that it goes between float and peek modes multiple times.

Expected Behavior

Panel should appear in the same position like this:

74dc0vxda5

Possible Solution

Remove this line:

panel.reposition(-Math.round(Math.random() * 100) - 20, (Math.round(Math.random() * 100) + 20) * (this.isAtTop() ? 1 : -1));

I am sure the purpose for this line. Everything seems to work great without it, even when the debug bar is positioned at the top of the viewport. Maybe I just didn't test enough scenarios to figure out why this is needed?

@dg dg closed this in 0a3a641 Sep 21, 2018
dg added a commit that referenced this issue Sep 21, 2018
dg added a commit that referenced this issue Sep 21, 2018
dg added a commit that referenced this issue Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.