Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New live dumps puts location before dump #343

Closed
adrianbj opened this issue Feb 20, 2019 · 2 comments
Closed

New live dumps puts location before dump #343

adrianbj opened this issue Feb 20, 2019 · 2 comments

Comments

@adrianbj
Copy link
Contributor

@adrianbj adrianbj commented Feb 20, 2019

Version: 2.6

Bug Description

image

Expected Behavior

If I change this line

Dumper::LIVE => true,
to false, then it looks as expected:

image

so it's got something to do with the way live dumps render.

@adrianbj

This comment has been minimized.

Copy link
Contributor Author

@adrianbj adrianbj commented Feb 23, 2019

Just wanted to mention that this is not new to 2.6. Live dumps in 2.5 also caused this.

Replacing:

el.appendChild(build(JSON.parse(el.getAttribute('data-tracy-dump')), snapshot, el.classList.contains('tracy-collapsed')));

with:

el.insertBefore(build(JSON.parse(el.getAttribute('data-tracy-dump')), snapshot, el.classList.contains('tracy-collapsed')), el.lastChild);

seems to fix it and works whether the location is showing or not.

@dg

This comment has been minimized.

Copy link
Member

@dg dg commented Feb 26, 2019

Yes, it is right fix.

@dg dg closed this Feb 26, 2019
dg added a commit that referenced this issue Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.