Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password key hide real data type #380

Closed
janbarasek opened this issue Aug 27, 2019 · 0 comments
Closed

Password key hide real data type #380

janbarasek opened this issue Aug 27, 2019 · 0 comments

Comments

@janbarasek
Copy link
Contributor

@janbarasek janbarasek commented Aug 27, 2019

Version: 2.6.4

Bug Description

In case of password property or key array Tracy hide value automatically and render string *****.

I suggest in case of no scalar type render name of type with hidden value, because now I can not say if password key is string or object.

Snímek obrazovky 2019-08-27 v 14 31 51

Steps To Reproduce

Very simply:

public function process(): void
{
	$this->setUser([
		'user' => 'Jan',
		'password' => new ArrayHash(),
	]);
}

private function setUser(array $haystack): void
{
	$e(); // Throw error
}

On follow Tracy arguments:

Snímek obrazovky 2019-08-27 v 14 38 38

By the way, hiding items is not effective because the password is still visible in the title!

Snímek obrazovky 2019-08-27 v 14 40 39

Snímek obrazovky 2019-08-27 v 14 41 10

I will report it in next issue as security bug.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.