Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay panel rendering #160

Merged
merged 1 commit into from May 21, 2016
Merged

Delay panel rendering #160

merged 1 commit into from May 21, 2016

Conversation

@JanTvrdik
Copy link
Contributor

JanTvrdik commented May 5, 2016

Similarly to how we delay rendering of invisible dumps we should delay rendering of invisible panels and render them the first time they became visible. This is especially important when bar panel contains a lot of HTML (for example query log).

What do you think?

@dg dg force-pushed the nette:master branch 6 times, most recently from 7f3fd63 to bbc898e May 16, 2016
@JanTvrdik JanTvrdik force-pushed the JanTvrdik:pr/lazy_panel_rendering branch from 2d53b24 to 3552156 May 21, 2016
@JanTvrdik JanTvrdik force-pushed the JanTvrdik:pr/lazy_panel_rendering branch from 3552156 to 5ee0d72 May 21, 2016
@JanTvrdik

This comment has been minimized.

Copy link
Contributor Author

JanTvrdik commented May 21, 2016

@dg This is now ready to merge from my point of view.

@JanTvrdik

This comment has been minimized.

Copy link
Contributor Author

JanTvrdik commented May 21, 2016

It breaks toggle persisting in window-mode, I'll look into it.

It did not work before, so it's fine 😄

@dg

This comment has been minimized.

Copy link
Member

dg commented May 21, 2016

Great!

@dg dg merged commit c5d2579 into nette:master May 21, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@JanTvrdik JanTvrdik deleted the JanTvrdik:pr/lazy_panel_rendering branch May 21, 2016
@adrianbj

This comment has been minimized.

Copy link
Contributor

adrianbj commented May 21, 2016

Thanks @JanTvrdik - this is awesome!

@dg

This comment has been minimized.

Copy link
Member

dg commented May 22, 2016

@JanTvrdik there is problem when panel contains dumps with LIVE => TRUE, it is not inited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.