Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar in session: remove undispatched bars after 60 seconds #234

Closed
wants to merge 1 commit into from

Conversation

@matej21
Copy link
Contributor

matej21 commented Nov 23, 2016

No description provided.

@milo

This comment has been minimized.

Copy link
Member

milo commented Nov 24, 2016

Not sure it is correct solution, but it probably solve my issue. I can find 2MB - 90MB session files with _tracy|a:3:{s:8:"redirect";N;s:3:"bar"; ..... junk.

@dg

This comment has been minimized.

Copy link
Member

dg commented Dec 3, 2016

Queue is limited that there could be a maximum of 5 items, so it shouldn't accumulate data…

$queue = array_slice(array_filter((array) $queue), -5, NULL, TRUE);

@milo can you try to explore what is wrong?

@JanTvrdik

This comment has been minimized.

Copy link
Contributor

JanTvrdik commented Dec 3, 2016

Is it possible that those 5 items could never expire?

@milo

This comment has been minimized.

Copy link
Member

milo commented Dec 4, 2016

@dg Thanks to pointing this code. It takes some sense to me now, even I cannot reproduce it.

My guess is, I made some huge dump (~20MB) by mistake and I stopped loading in a browser, so item wasn't picked up. Than again and again wasn't picked up. Than I fixed this dump, but data remains in the session, because ordinary traffic is one tracy bar, or two on redirection.

@dg dg force-pushed the nette:master branch from ed1048f to ff2e4be Dec 7, 2016
@dg dg closed this in 9150320 Dec 7, 2016
dg added a commit that referenced this pull request Dec 7, 2016
@matej21 matej21 deleted the matej21:session_bar_gc branch Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.