Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display AJAX bar for Fetch requests #249

Merged
merged 1 commit into from Feb 27, 2017
Merged

Display AJAX bar for Fetch requests #249

merged 1 commit into from Feb 27, 2017

Conversation

@jiripudil
Copy link
Contributor

jiripudil commented Feb 21, 2017

  • bug fix? no
  • new feature? yes
  • BC break? no
  • doc PR: doesn't seem necessary

This pull request adds AJAX debug bar support for requests made via Fetch API instead of XMLHttpRequest.

There is one caveat which, however, should imo be addressed in the userland: fetch() must be sent with credentials set to include or same-origin for the cookies to be passed and thus for the debug bar session storage to work. This implementation sanely defaults to same-origin if the option is not provided, but if the user sends their own Request object, the credentials option defaults to omit if not provided, and cannot be overridden. I believe it should be left up to the user to handle such situations.

@dg dg merged commit 8fcdc40 into nette:master Feb 27, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jiripudil jiripudil deleted the jiripudil:feature/ajax-via-fetch branch Feb 27, 2017
dg added a commit that referenced this pull request May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.