Helpers: take host name from SERVER_NAME instead of HTTP_HOST #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg
force-pushed
the
master
branch
3 times, most recently
from
c5c5bab
to
0d0dbd8
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
17ddd81
to
9cb1b0f
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
6fd4a05
to
3f0d0cb
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
746b339
to
a2663ed
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
bb44626
to
526708d
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
7335fbf
to
5f47b0d
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
9b6ddf1
to
44b485d
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
c4fc317
to
20c031f
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
dbabb37
to
eb2e772
Compare
dg
force-pushed
the
master
branch
6 times, most recently
from
de3ad52
to
191c0d2
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
2b958bb
to
f36b649
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
68b0ec8
to
344c772
Compare
|
Why do you think SERVER_NAME can't be spoofed in the same way? |
|
@dg https://www.geeksforgeeks.org/what-is-the-difference-between-http_host-and-server_name-in-php/ |
|
The question should have been different. Why I'd like to see SERVER_NAME instead of spoofed HTTP_HOST in source line? HTTP_HOST better reflects what is in the address bar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
bug fix
BC break? yes
Hi,
it is better to identify server host name by secure directive SERVER_NAME, because HTTP_HOST is not secure and can be changed by user.
https://www.skeletonscribe.net/2013/05/practical-http-host-header-attacks.html