Helpers: take host name from SERVER_NAME instead of HTTP_HOST - #309
Closed
adaamz wants to merge 10 commits into
Closed
Helpers: take host name from SERVER_NAME instead of HTTP_HOST#309adaamz wants to merge 10 commits into
adaamz wants to merge 10 commits into
Conversation
dg
force-pushed
the
master
branch
3 times, most recently
from
August 13, 2018 17:05
c5c5bab to
0d0dbd8
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
September 30, 2018 18:46
17ddd81 to
9cb1b0f
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
October 29, 2018 16:33
6fd4a05 to
3f0d0cb
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
November 5, 2018 15:12
746b339 to
a2663ed
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
February 10, 2019 23:05
bb44626 to
526708d
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
February 17, 2019 18:09
90fac79 to
7189fbf
Compare
dg
force-pushed
the
master
branch
17 times, most recently
from
February 21, 2019 03:05
ef4eb5f to
466250c
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
February 26, 2019 02:02
39296b0 to
cbf05bb
Compare
Member
|
Why do you think SERVER_NAME can't be spoofed in the same way? |
Author
|
@dg https://www.geeksforgeeks.org/what-is-the-difference-between-http_host-and-server_name-in-php/ |
Member
|
The question should have been different. Why I'd like to see SERVER_NAME instead of spoofed HTTP_HOST in source line? HTTP_HOST better reflects what is in the address bar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bug fix
BC break? yes
Hi,
it is better to identify server host name by secure directive SERVER_NAME, because HTTP_HOST is not secure and can be changed by user.
https://www.skeletonscribe.net/2013/05/practical-http-host-header-attacks.html