Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix path to composer.lock in info.panel.phtml #313

Closed

Conversation

@zdenekgebauer
Copy link

zdenekgebauer commented Aug 20, 2018

fixes warning about incorrect path to composer.lock when folder "vendor" is not placed in root

  • bug fix / new feature?
  • BC break? yes/no
  • doc PR: nette/docs#???

Line $composer = @json_decode(file_get_contents($lockFile)); throws warning about incorrect $lockFile when composer.json contains config "vendor-dir": "some/subdir".
I use workaround with $_SERVER['DOCUMENT_ROOT']. Is there any better solution how to retrieve composer.lock?

@dg dg force-pushed the nette:master branch from 017e086 to 31e8c93 Sep 13, 2018
@dg dg force-pushed the nette:master branch 3 times, most recently from 17ddd81 to 9cb1b0f Sep 24, 2018
@dg

This comment has been minimized.

Copy link
Member

dg commented Sep 30, 2018

fixed 9be5b49

dg added a commit that referenced this pull request Sep 30, 2018
@dg dg closed this in 800cb47 Sep 30, 2018
dg added a commit that referenced this pull request Oct 5, 2018
dg added a commit that referenced this pull request Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.