Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bar.js: send with Content-type: application/javascript #322

Merged
merged 1 commit into from Oct 3, 2018

Conversation

@jakubboucek
Copy link
Contributor

jakubboucek commented Oct 3, 2018

  • Type: bug fix
  • BC break: yes, but probably no effective
  • No tests or docs affected or applied

Tracy is sending Tracy\Bar components with Content-Type: text/javascript.

According to RFC 4329 (chapter 7.1) is text/javascript obsolete and should be used application/javascript instead.

In real case it make light impediment to right detect, and process response. For example .htaccess in nette/web-project is set DEFLATE filter only for application/javascript mime. I mean it's just mistake, not intentionally.

@dg

This comment has been minimized.

Copy link
Member

dg commented Oct 3, 2018

Thanks

@dg dg merged commit d7fea3e into nette:master Oct 3, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 73.538%
Details
dg added a commit that referenced this pull request Oct 3, 2018
dg added a commit that referenced this pull request Oct 5, 2018
@jakubboucek jakubboucek deleted the jakubboucek:fix-bar-js-content-type branch Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.