Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append <div id=tracy-debug> into BODY if possible #335

Closed
wants to merge 1 commit into from

Conversation

@EvilKraft
Copy link

EvilKraft commented Nov 8, 2018

  • bug fix
  • BC break: yes

This fix appends tracy bar into tag BODY if it exists.
Otherwise into documentElement

@JanTvrdik

This comment has been minimized.

Copy link
Contributor

JanTvrdik commented Nov 8, 2018

why?

@EvilKraft

This comment has been minimized.

Copy link
Author

EvilKraft commented Nov 8, 2018

Because of HTML validation. DIV should not be outside BODY

@dg

This comment has been minimized.

Copy link
Member

dg commented Nov 8, 2018

Thanks

@dg dg closed this in 0b371a1 Nov 8, 2018
dg added a commit that referenced this pull request Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.