Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dumper: do not quote dumped keys #340

Closed
wants to merge 2 commits into from

Conversation

@milo
Copy link
Member

commented Feb 15, 2019

Is there any reason for quoting dumped array keys/object property names? For example:

array (2)
    Accept => "application/json" (16)
    "User-Agent" => "milo/http-client-v5.2" (21)

Empty string is preserver quoted.

@dg

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

It should preserve quotes in keys like "hello " too.

@dg dg force-pushed the nette:master branch from accb378 to 2d63d3b Feb 15, 2019

Miloslav Hůla added 2 commits Feb 15, 2019

@milo milo force-pushed the milo:drop-key-quotes branch from 5ad9a10 to cede4ab Feb 15, 2019

@milo

This comment has been minimized.

Copy link
Member Author

commented Feb 15, 2019

Something like this?

@dg dg closed this in ec1ba86 Feb 15, 2019

@dg

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

I made it a little easier.

dg added a commit that referenced this pull request Feb 15, 2019
dg added a commit that referenced this pull request Feb 15, 2019
@milo

This comment has been minimized.

Copy link
Member Author

commented Feb 15, 2019

Great. Thank you!

dg added a commit that referenced this pull request Feb 15, 2019
dg added a commit that referenced this pull request Feb 16, 2019
dg added a commit that referenced this pull request Feb 17, 2019
dg added a commit that referenced this pull request Feb 17, 2019
dg added a commit that referenced this pull request Feb 17, 2019
dg added a commit that referenced this pull request Feb 17, 2019
dg added a commit that referenced this pull request Feb 17, 2019
dg added a commit that referenced this pull request Feb 17, 2019
dg added a commit that referenced this pull request Feb 17, 2019
dg added a commit that referenced this pull request Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.