Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dumper: do not quote dumped keys #340

Closed
wants to merge 2 commits into from
Closed

Conversation

@milo
Copy link
Member

@milo milo commented Feb 15, 2019

Is there any reason for quoting dumped array keys/object property names? For example:

array (2)
    Accept => "application/json" (16)
    "User-Agent" => "milo/http-client-v5.2" (21)

Empty string is preserver quoted.

@dg
Copy link
Member

@dg dg commented Feb 15, 2019

It should preserve quotes in keys like "hello " too.

Loading

@milo milo force-pushed the drop-key-quotes branch from 5ad9a10 to cede4ab Feb 15, 2019
@milo
Copy link
Member Author

@milo milo commented Feb 15, 2019

Something like this?

Loading

@dg dg closed this in ec1ba86 Feb 15, 2019
@dg
Copy link
Member

@dg dg commented Feb 15, 2019

I made it a little easier.

Loading

@milo
Copy link
Member Author

@milo milo commented Feb 15, 2019

Great. Thank you!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants