Skip to content

/ tracy

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message max length #383

Merged
merged 17 commits into from Sep 13, 2019
Merged

Message max length #383

merged 17 commits into from Sep 13, 2019

Conversation

@janbarasek
Copy link
Contributor

janbarasek commented Sep 11, 2019

  • new feature
  • BC break? yes

In case of extremely length error message BlueScreen log full message. I think it should be truncated for example to 32768 characters.

Example code: throw new \Exception(str_repeat('abcd ', 10000));.

Snímek obrazovky 2019-09-11 v 12 50 23
dg and others added 12 commits Oct 9, 2017
@dg
opened 2.7-dev
57d7ec8
@dg
bar: replaced attribute 'rel' with 'data-tracy-action' for closing & …
250c622 
…open-to-window links
@dg
Bluescreen: footer is always on bottom
e3996eb
@dg
BlueScreen: removed source from footer
ee22c3c
@dg
TracyExtension: added getConfigSchema()
Loading status checks…
fdaefa2
@dg
Logger: added priority to exception file name
1d8b780
@dg
tested against PHP 7.4
Loading status checks…
6060d6c
@dg
BlueScreen: keysToHide respected in title [Closes #381]
Loading status checks…
a6aaefb
@dg
Dumper: hidden values are rendered with variable type [Closes #380]
Loading status checks…
4434921
@janbarasek
BlueScreen: Add truncate helper to exception message
Loading status checks…
52925ca
@janbarasek
Merge branch 'master' of github.com:nette/tracy
12d2b18
@janbarasek
Merge branch 'master' into message-max-length
Loading status checks…
a0a63fd
@JanTvrdik
JanTvrdik reviewed Sep 11, 2019
View changes
src/Tracy/Helpers.php Outdated Show resolved Hide resolved
@dg dg force-pushed the nette:master branch 2 times, most recently from e42541b to 9270a2c Sep 13, 2019
dg and others added 5 commits Sep 13, 2019
@dg
Dumper: added truncateString()
Loading status checks…
f747910
@janbarasek
Fix conflict in Master
1bed519
@janbarasek
Merge branch 'master' into message-max-length
Loading status checks…
3eba6e3
@janbarasek
Replace Helpers::truncate to Dumper::encodeString
Loading status checks…
56baa2a
@janbarasek
Fix codestandard test
Loading status checks…
2f4d7bd
@dg dg force-pushed the nette:master branch from b69d510 to f98616e Sep 13, 2019
@dg

This comment has been minimized.

Sign in to view
Copy link
Member

dg commented Sep 13, 2019

thanks
@dg dg merged commit 9ce7372 into nette:master Sep 13, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on message-max-length at 70.94%
Details
dg added a commit that referenced this pull request Sep 13, 2019
@janbarasek @dg
Bluescreen: added length limit for exception message (#383)
Loading status checks…
d97208b
dg added a commit that referenced this pull request Sep 24, 2019
@janbarasek @dg
Bluescreen: added length limit for exception message (#383)
fc37ced
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanTvrdik JanTvrdik

@dg dg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@janbarasek @dg @JanTvrdik
You can’t perform that action at this time.