Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message max length #383

Merged
merged 17 commits into from Sep 13, 2019
Merged

Message max length #383

merged 17 commits into from Sep 13, 2019

Conversation

@janbarasek
Copy link
Contributor

janbarasek commented Sep 11, 2019

  • new feature
  • BC break? yes

In case of extremely length error message BlueScreen log full message. I think it should be truncated for example to 32768 characters.

Example code: throw new \Exception(str_repeat('abcd ', 10000));.

Snímek obrazovky 2019-09-11 v 12 50 23

src/Tracy/Helpers.php Outdated Show resolved Hide resolved
@dg dg force-pushed the nette:master branch 2 times, most recently from e42541b to 9270a2c Sep 13, 2019
@dg dg force-pushed the nette:master branch from b69d510 to f98616e Sep 13, 2019
@dg

This comment has been minimized.

Copy link
Member

dg commented Sep 13, 2019

thanks

@dg dg merged commit 9ce7372 into nette:master Sep 13, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on message-max-length at 70.94%
Details
dg added a commit that referenced this pull request Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.